Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test:user.eids[].{inserter,matcher,mm} #3469

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Test:user.eids[].{inserter,matcher,mm} #3469

merged 2 commits into from
Sep 30, 2024

Conversation

marki1an
Copy link
Collaborator

@marki1an marki1an commented Sep 26, 2024 •
edited
Loading

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes? Are there any

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@marki1an marki1an added the tests Functional or other tests label Sep 26, 2024
@marki1an marki1an self-assigned this Sep 26, 2024
@marki1an marki1an changed the base branch from master to new-fields-for-eids September 26, 2024 13:45
@Compile-Ninja Compile-Ninja merged commit 4d0da37 into new-fields-for-eids Sep 30, 2024
@Compile-Ninja Compile-Ninja deleted the tests/support-ORTB-2.6-202409 branch September 30, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osulzhenko osulzhenko osulzhenko approved these changes

Assignees

@marki1an marki1an

Labels
tests Functional or other tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marki1an @osulzhenko @Compile-Ninja